From c04f179b9902532a8d5db0c2ebd98460a70fc652 Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 26 Jul 2026 14:10:48 +0200 Subject: making repl work --- src/fen.cpp | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 138 insertions(+) create mode 100644 src/fen.cpp (limited to 'src/fen.cpp') diff --git a/src/fen.cpp b/src/fen.cpp new file mode 100644 index 0000000..8244425 --- /dev/null +++ b/src/fen.cpp @@ -0,0 +1,138 @@ +#include "board.hpp" +#include +#include +#include +#include + +bool WHITE = true; +bool BLACK = false; + +void setBoardFen(std::string fen, board *b) { + // example fen rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1 + int file = 0; + int rank = 0; + + std::string castle = ""; + + enum parserState { + POSITION, + TURN, + CASTLE, + ENPASSANT, + CLOCK1, + CLOCK2, + }; + parserState state = POSITION; + + for (int i = 0; i < fen.length(); i++) { + std::printf("state: %d\n", state); + std::printf("doing: %c\n", fen[i]); + if (fen[i] == ' ') { + if (state == POSITION) { + state = TURN; + continue; + } + if (state == TURN) { + state = CASTLE; + continue; + } + if (state == CASTLE) { + state = ENPASSANT; + continue; + } + if (state == ENPASSANT) { + state = CLOCK1; + continue; + } + if (state == CLOCK1) { + state = CLOCK2; + continue; + } + } + if (state == ENPASSANT) { + continue; + } + if (state == CASTLE) { + if (fen[i] == '-') { + castle = "-"; + continue; + } + if (toupper(fen[i]) == 'K') { + castle += fen[i]; + continue; + } + if (toupper(fen[i]) == 'Q') { + castle += fen[i]; + continue; + } + } + if (state == TURN) { + if (toupper(fen[i]) == 'W') { + b->turn = WHITE; + continue; + } + if (toupper(fen[i]) == 'B') { + b->turn = BLACK; + continue; + } + } + if (state == POSITION) { + if (isdigit(fen[i])) { + int move = fen[i] - '0'; + file += move; + if (file > 8) { + std::println("Fatal: file was to big"); + return; // malformed rank + } + continue; + } + if (fen[i] == '/') { + file = 0; + rank++; + if (rank > 8) { + std::println("Fatal: rank was to big"); + return; // malformed rank + } + continue; + } + if (toupper(fen[i]) == 'N') { + Piece piece = createPiece(KNIGHT, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + if (toupper(fen[i]) == 'R') { + Piece piece = createPiece(ROOK, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + if (toupper(fen[i]) == 'Q') { + Piece piece = createPiece(QUEEN, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + if (toupper(fen[i]) == 'B') { + Piece piece = createPiece(BISHOP, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + if (toupper(fen[i]) == 'P') { + Piece piece = createPiece(PAWN, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + if (toupper(fen[i]) == 'K') { + Piece piece = createPiece(KING, isupper(fen[i])); + b->pieces[rank * 8 + file] = piece; + file++; + continue; + } + } + break; + } + b->castle = castle.empty() ? "-" : castle; +} -- cgit v1.2.3 From 54704ebd1b03b3f33bcd7d2905a8538f5a842f0f Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 26 Jul 2026 15:45:51 +0200 Subject: i am stupid --- src/board.cpp | 8 +++++++- src/board.hpp | 1 - src/fen.cpp | 5 +++-- src/fen.hpp | 10 ++++------ src/main.cpp | 12 +++++++----- 5 files changed, 21 insertions(+), 15 deletions(-) (limited to 'src/fen.cpp') diff --git a/src/board.cpp b/src/board.cpp index cbafcc6..201bd3a 100644 --- a/src/board.cpp +++ b/src/board.cpp @@ -1,11 +1,14 @@ #include "board.hpp" +#include #include #include #include #include #include +#include const char toChar(pieceType type) { + switch (type) { case NONE: return '.'; @@ -22,7 +25,7 @@ const char toChar(pieceType type) { case KING: return 'K'; default: - return '?'; + std::unreachable(); } } @@ -80,6 +83,9 @@ void printBoard(board *b) { std::println(); std::println("Turn: {}", b->turn ? "White" : "Black"); + + assert(b->castle != ""); + std::println("Castling: {}", b->castle); } diff --git a/src/board.hpp b/src/board.hpp index f085326..23f89ad 100644 --- a/src/board.hpp +++ b/src/board.hpp @@ -43,7 +43,6 @@ struct Move { bool operator==(const Move &) const = default; }; void printBoard(board *b); -void setBoardFen(std::string fen, board *b); Piece createPiece(pieceType type, bool color, bool moved = false); void PlayMove(Move move, board *b); // TODO implement diff --git a/src/fen.cpp b/src/fen.cpp index 8244425..a6773c2 100644 --- a/src/fen.cpp +++ b/src/fen.cpp @@ -1,3 +1,4 @@ +#include "fen.hpp" #include "board.hpp" #include #include @@ -94,13 +95,13 @@ void setBoardFen(std::string fen, board *b) { return; // malformed rank } continue; - } + }; if (toupper(fen[i]) == 'N') { Piece piece = createPiece(KNIGHT, isupper(fen[i])); b->pieces[rank * 8 + file] = piece; file++; continue; - } + }; if (toupper(fen[i]) == 'R') { Piece piece = createPiece(ROOK, isupper(fen[i])); b->pieces[rank * 8 + file] = piece; diff --git a/src/fen.hpp b/src/fen.hpp index 55d47ae..19f88e2 100644 --- a/src/fen.hpp +++ b/src/fen.hpp @@ -1,11 +1,9 @@ -#ifndef SRC_BOARD_H_ -#define SRC_BOARD_H_ +#ifndef SRC_FEN_H_ +#define SRC_FEN_H_ #include #include "board.hpp" -using namespace std; - -void setBoardFen(string fen, board *b); -#endif /* SRC_BOARD_H_ */ +void setBoardFen(std::string fen, board *b); +#endif /* SRC_FEN_H_ */ diff --git a/src/main.cpp b/src/main.cpp index d59195d..ba5e57c 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1,4 +1,5 @@ #include "board.hpp" +#include "fen.hpp" #include "moves.hpp" #include #include @@ -66,16 +67,17 @@ int main(int argc, char **argv) { std::cout << command << "\n"; transform(command.begin(), command.end(), command.begin(), ::toupper); - if (command.length() != 4) { - std::cout << "Unknown Command, use EXIT to exit"; - std::println(); - continue; - } if (command == "EXIT") { std::println(); std::cout << "Exiting...\n"; return 0; } + + if (command.length() != 4) { + std::cout << "Unknown Command, use EXIT to exit"; + std::println(); + continue; + } if (!isValidChessFile(command[0])) { std::cout << "ERROR: Expected valid file at first place"; std::println(); -- cgit v1.2.3 From a46558e0aab30eb88ac3cafac8d490174bd4785f Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 26 Jul 2026 16:33:03 +0200 Subject: making everything more strict + fixing the warnings/error --- .github/workflows/cmake-single-platform.yml | 5 ++++- CMakeLists.txt | 19 +++++++++++++++++++ src/board.cpp | 11 +++++------ src/board.hpp | 2 +- src/fen.cpp | 2 +- src/main.cpp | 2 +- src/moves.cpp | 5 +++-- 7 files changed, 34 insertions(+), 12 deletions(-) (limited to 'src/fen.cpp') diff --git a/.github/workflows/cmake-single-platform.yml b/.github/workflows/cmake-single-platform.yml index c02bed4..844556e 100644 --- a/.github/workflows/cmake-single-platform.yml +++ b/.github/workflows/cmake-single-platform.yml @@ -31,10 +31,13 @@ jobs: env: CC: gcc-14 CXX: g++-14 - run: cmake -B build -S . + run: cmake -B build -S . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON - name: Build env: CC: gcc-14 CXX: g++-14 run: cmake --build build + + - name: Run clang-tidy + run: clang-tidy src/*.cpp -p build diff --git a/CMakeLists.txt b/CMakeLists.txt index 3782845..3f5a42f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,3 +14,22 @@ file(GLOB_RECURSE SOURCE_FILES src/*.c src/*.cpp src/*.h src/*.hpp) add_executable(${PROJECT_NAME} ${SOURCE_FILES}) target_include_directories(${PROJECT_NAME} PRIVATE src) + +if (MSVC) + target_compile_options(${PROJECT_NAME} PRIVATE /W4 /WX) +else() + target_compile_options(${PROJECT_NAME} PRIVATE + -Wall + -Wextra + -Wpedantic + -Werror + ) +endif() + +target_compile_options(${PROJECT_NAME} PRIVATE + -fsanitize=address,undefined +) + +target_link_options(${PROJECT_NAME} PRIVATE + -fsanitize=address,undefined +) diff --git a/src/board.cpp b/src/board.cpp index 081cc7d..172a9be 100644 --- a/src/board.cpp +++ b/src/board.cpp @@ -5,13 +5,11 @@ #include #include #include -#include - -const char toChar(pieceType type) { +char toChar(pieceType type) { switch (type) { case NONE: - return '.'; + return '.'; case PAWN: return 'P'; case KNIGHT: @@ -25,7 +23,8 @@ const char toChar(pieceType type) { case KING: return 'K'; default: - assert(false && "Unknown piece"); + std::cout << "\n" << type << "\n"; + assert(false && "Unknown piece" && type); return '?'; } } @@ -90,4 +89,4 @@ void printBoard(board *b) { std::println("Castling: {}", b->castle); } -void PlayMove(Move move, board *b) { return; } +// void PlayMove(Move move, board *b) { return; } diff --git a/src/board.hpp b/src/board.hpp index 23f89ad..afdb938 100644 --- a/src/board.hpp +++ b/src/board.hpp @@ -13,7 +13,7 @@ enum pieceType { KING, }; -const char toChar(pieceType type); +char toChar(pieceType type); struct Piece { bool color; diff --git a/src/fen.cpp b/src/fen.cpp index a6773c2..9c3154c 100644 --- a/src/fen.cpp +++ b/src/fen.cpp @@ -25,7 +25,7 @@ void setBoardFen(std::string fen, board *b) { }; parserState state = POSITION; - for (int i = 0; i < fen.length(); i++) { + for (uint i = 0; i < fen.length(); i++) { std::printf("state: %d\n", state); std::printf("doing: %c\n", fen[i]); if (fen[i] == ' ') { diff --git a/src/main.cpp b/src/main.cpp index 7a6e7f4..261c19d 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -127,7 +127,7 @@ int main(int argc, char **argv) { continue; } std::println(); - PlayMove(move, &b); + // PlayMove(move, &b); // todo implement b.MoveClock++; b.turn = !b.turn; printBoard(&b); diff --git a/src/moves.cpp b/src/moves.cpp index 2ff8ed6..f02dfbe 100644 --- a/src/moves.cpp +++ b/src/moves.cpp @@ -1,5 +1,6 @@ #include #include +#include #include "board.hpp" #include "moves.hpp" @@ -11,7 +12,7 @@ std::vector GetLegalMoves(board *b) { constexpr std::array rook_Moves{-1, 1, 8, -8}; constexpr std::array bishop_Moves{-9, 9, -7, 7}; - for (int i = 0; i < sizeof(b->pieces) / sizeof(b->pieces[0]); i++) { + for (uint i = 0; i < sizeof(b->pieces) / sizeof(b->pieces[0]); i++) { Piece piece = b->pieces[i]; if (piece.type == NONE) { continue; @@ -42,7 +43,7 @@ Position IndexToPosition(int i) { void GenerateSlidingMoves(board *b, int from, const std::array &directions, std::vector &moves) { - for (int i = 0; i < directions.size(); i++) { + for (uint i = 0; i < directions.size(); i++) { int direction = directions[i]; int i2 = from; -- cgit v1.2.3